Skip to content

feat: terracotta#282

Open
chocodev11 wants to merge 7 commits into
Steel-Foundation:masterfrom
chocodev11:terracotta
Open

feat: terracotta#282
chocodev11 wants to merge 7 commits into
Steel-Foundation:masterfrom
chocodev11:terracotta

Conversation

@chocodev11

Copy link
Copy Markdown
Contributor

No description provided.

}

impl GlazedTerracottaBlock {
/// Creates a new glazed terracotta block behavior.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is needed because its pub

use crate::behavior::block::BlockBehavior;
use crate::behavior::context::BlockPlaceContext;

/// Vanilla `GlazedTerracottaBlock` placement facing.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is needed because its pub

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh ok forgot that, to long no coding

}

impl GlazedTerracottaBlock {
/// Creates a new glazed terracotta block behavior.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is needed because its pub

@JunkyDeveloper JunkyDeveloper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, LGTM forgot the pub thing, can't resolve anymore??

Also Lint are not working

@github-actions

Copy link
Copy Markdown

This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes.

# Conflicts:
#	steel-core/src/behavior/blocks/mod.rs
@github-actions

Copy link
Copy Markdown

Conflicts have been resolved! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants